Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iceberg] Improved ByteBuffer string conversion for Iceberg manifests #5008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0dunay0
Copy link

@0dunay0 0dunay0 commented Feb 3, 2025

Purpose

Paimon's Iceberg compatibility tables partitioned by a string field doesn't return any results when queried by an equality predicate on the partition field.

  • The snapshot file's partition summary lower and upper bounds have a null character suffix.
  • The column stats in the manifest files also contain null character suffix.

The effect of these is clients skip all the data files for the Iceberg table during scan planning. See the linked issue for examples.

Linked issue: #5007

Tests

  • Added a new test case in IcebergCompatibilityTest to verify the snapshot metadata files no longer contain the \u000 padding.
  • Added extensive test cases for the IcebergConversions CHAR/VARCHAR case.

API and Format

N/A

Documentation

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant